Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IntoFuture bug #944

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Fix IntoFuture bug #944

merged 4 commits into from
Jul 19, 2022

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jul 19, 2022

The use of into_future broke, and we didn't notice. This fixes the issue, and adds into_future testing to CI. Once IntoFuture lands on stable, this can be removed.

@rylev rylev requested a review from cataggar July 19, 2022 12:35
@rylev rylev requested a review from yoshuawuyts July 19, 2022 13:05
#![allow(dead_code)]
use super::*;
/// A pageable stream that yields items of type `T`
///
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, remove

@cataggar
Copy link
Member

Can #687 be closed?

@rylev
Copy link
Contributor Author

rylev commented Jul 19, 2022

@cataggar not quite. When the IntoFuture language feature stabilizes, the into_future feature flag needs to be removed and the example code needs to be updated to not directly call into_future. This is what #687 still does.

@rylev rylev merged commit 006aee1 into Azure:main Jul 19, 2022
@rylev rylev deleted the fix-into-future-bug branch July 19, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants