Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure header name Content-MD5 is lower-cased #929

Merged
merged 2 commits into from
Jul 13, 2022
Merged

Make sure header name Content-MD5 is lower-cased #929

merged 2 commits into from
Jul 13, 2022

Conversation

evanxg852000
Copy link
Contributor

Should close this

bmc-msft
bmc-msft suggested changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@bmc-msft bmc-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the HeaderName value provided by azure_core::headers::CONTENT_MD5

Additionally, instead of a hard-coded blob name, can this be a parameter to the example?

@bmc-msft bmc-msft self-requested a review July 13, 2022 21:02
@bmc-msft bmc-msft merged commit f361934 into Azure:main Jul 13, 2022
@bmc-msft
Copy link
Contributor

Thanks for the contribution!

@evanxg852000 evanxg852000 mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmc-msft bmc-msft bmc-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PutBlockList operation panics
2 participants
@evanxg852000 @bmc-msft