Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose Storage Options when creating storage clients #922

Closed
wants to merge 3 commits into from

Conversation

bmc-msft
Copy link
Contributor

This enables setting pipeline options at client configuration time,
which is required to set policies, such as request retry configuration.

Brian Caswell added 3 commits July 12, 2022 10:49
This enables setting pipeline options at client configuration time,
which is required to set policies, such as request retry configuration.
@bmc-msft
Copy link
Contributor Author

Note, I recognize this goes in the opposite direction of #886 , but think this is a path to enable setting policies until a design for the builder pattern used for clients has been defined.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @yoshuawuyts comment on what the plans are for the client builder pattern, but I'm unsure about merging this if it's just going to change in a few days.

@yoshuawuyts
Copy link
Contributor

Thanks for tagging me @rylev! - Yeah, this pulls us in the exact opposite direction of #886, and it would probably make more sense if we figure the API out in the Cosmos SDK first, and then migrate this API over after to match that.

@bmc-msft
Copy link
Contributor Author

Agreed. This was discussed at the SDK meeting. I will close for now.

@bmc-msft bmc-msft closed this Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants