use clap parser in cosmos examples
#884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Jul 1, 2022
|
|
||
| let doc = MySampleStruct { | ||
| id, | ||
| id: format!("unique_id{}", 100), |
There was a problem hiding this comment.
I know it was this way before, but "unique_id100".to_owned() might be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively small change, but it moves the cosmos examples from our custom parsing code to the commonly-used
clapcommand line parser crate. The benefit of doing this is that it removes bespoke parsing code from insidefn mainto a declarative struct at the top of the file. The focus of the examples should be on how to use the Azure APIs, and not having several lines of command line parsing code at the start of eachfn mainshould make it a lot easier to skip to the core of the examples.I was reading over some examples, and found myself distracted by the initial parsing code in each file. Taken as a whole I think this should make the examples a lot easier to follow. Thanks!