revamp SAS builders to model operations #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2022 17:21
Moved to using the same Builder pattern implemented by Operations, such that required params are provided by the creator, with setters for optional fields.
rylev
approved these changes
Jul 1, 2022
| resource: AccountSasResource, | ||
| resource_type: AccountSasResourceType, | ||
| expiry: DateTime<Utc>, | ||
| permissions: AccountSasPermissions, |
There was a problem hiding this comment.
I wonder if we should not take permissions by default and just default to read permissions....
There was a problem hiding this comment.
Perhaps. Though, I am of a mind that as SAS urls are a way to convey access controls, I think it is reasonable to require the user to specify their desired intent.
The python SDK, which I'm the most familiar with, requires the credentials to be provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to using the same Builder pattern implemented by Operations, such that required params are provided by the creator, with setters for optional fields.