Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup storage clients #876

Merged
merged 8 commits into from
Jun 30, 2022
Merged

Cleanup storage clients #876

merged 8 commits into from
Jun 30, 2022

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jun 30, 2022

Worked on with @yoshuawuyts

This makes a bunch of the storage clients much simpler and also mirrors more how we do things in Cosmos:

  • Combined StorageClient and StorageAccountClient since there wasn't much reason for them to be separate.
  • Removed the old authentication code since now all storage clients use the pipeline and thus the Authentication policy
  • Removed http_client since we now only use the pipeline
  • Removed the external use of Arc since all clients should be cloneable
  • Removed a bunch of unnecessary extension traits in favor of just normal methods

@rylev rylev requested a review from bmc-msft June 30, 2022 10:00
@bmc-msft bmc-msft merged commit dc67285 into Azure:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants