Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More headers cleanup #864

Merged
merged 2 commits into from
Jun 28, 2022
Merged

More headers cleanup #864

merged 2 commits into from
Jun 28, 2022

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Jun 28, 2022

Some last changes to how we handle headers:

  • Consistent naming: get_optional_$type and get_$type
  • Add FromStr impls for more types so that get_as and get_optional_as just work.

@rylev rylev force-pushed the final-headers-cleanup branch from e28cc0d to 307aed4 Compare June 28, 2022 10:32
ctaggart
ctaggart approved these changes Jun 28, 2022
View reviewed changes
sdk/storage/src/core/headers/mod.rs
})
})
.transpose()
headers.get_optional_as(&CONTENT_CRC64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@rylev rylev merged commit 0d28f09 into Azure:main Jun 28, 2022
@rylev rylev mentioned this pull request Jul 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cataggar cataggar cataggar approved these changes

@ctaggart ctaggart ctaggart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rylev @ctaggart @cataggar