fix blob_storage_request #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctaggart
commented
Jun 28, 2022
| @@ -509,8 +507,16 @@ impl StorageAccountClient { | |||
| } | |||
|
|
|||
| /// Prepares' an `azure_core::Request`. | |||
| pub(crate) fn blob_storage_request(&self, http_method: azure_core::Method) -> Request { | |||
| Request::new(self.blob_storage_url().clone(), http_method) | |||
There was a problem hiding this comment.
Before, it was just creating a new Request.
| &self, | ||
| http_method: azure_core::Method, | ||
| ) -> azure_core::Result<Request> { | ||
| self.prepare_request( |
There was a problem hiding this comment.
The fix was to keep using the code that is in prepare_request.
rylev
approved these changes
Jun 28, 2022
| @@ -59,6 +59,12 @@ pub enum ServiceType { | |||
| Table, | |||
| } | |||
|
|
|||
| impl Default for ServiceType { | |||
There was a problem hiding this comment.
Why is Blob the default storage type?
| Url::parse(&format!("{}{}", queue_storage_url.as_str(), account)).unwrap(); | ||
| let filesystem_url = | ||
| Url::parse(&format!("{}{}", filesystem_url.as_str(), account)).unwrap(); | ||
| let blob_storage_url = Url::parse(&format!("{}{}", blob_storage_url, account)).unwrap(); |
There was a problem hiding this comment.
nit: we probably shouldn't unwrap here as account is user supplied and could be poorly formed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #861. It is a bug from switching over to pipelines. When
blob_storage_requestwas added in dd6b852, it skipped the existingprepare_requestcode that adds the necessary headers.This now works: