switch Method and StatusCode to http-types
#860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit acf6eda.
bmc-msft
reviewed
Jun 28, 2022
| @@ -26,7 +26,7 @@ impl HttpError { | |||
| let body = response.into_body().await; | |||
| error_code = error_code.or_else(|| get_error_code_from_body(&body)); | |||
| HttpError { | |||
| status: status.as_u16(), | |||
| status: status as u16, | |||
There was a problem hiding this comment.
Since we are re-exporting StatusCode now, can we make the error include the enum value instead of a u16? This will make dealing with contextualized errors significantly more straightforward.
There was a problem hiding this comment.
I think that is a good idea in a separate PR.
bmc-msft
reviewed
Jun 28, 2022
bmc-msft
reviewed
Jun 28, 2022
This reverts commit b645f76.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http-typeshas better representations of bothMethodandStatusCodeas I described in more detail earlier.I reverted the generated services code to make it easier to review.