Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Method & StatusCode to azure_core #852

Merged
merged 10 commits into from
Jun 27, 2022
Merged

add Method & StatusCode to azure_core #852

merged 10 commits into from
Jun 27, 2022

Conversation

cataggar
Copy link
Member

After getting feedback on #849, this is a subset of that change.

  • It does not change the StatusCode or Method being used. They are still from http in this pull request.

@cataggar cataggar mentioned this pull request Jun 25, 2022
Closed
@cataggar cataggar marked this pull request as ready for review June 25, 2022 17:59
rylev
rylev previously requested changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nitpicks.

sdk/core/src/error/http_error.rs Outdated Show resolved Hide resolved
sdk/core/src/error/http_error.rs Outdated Show resolved Hide resolved
sdk/core/src/http_client/reqwest.rs Outdated Show resolved Hide resolved
sdk/core/src/http_client/reqwest.rs Outdated Show resolved Hide resolved
sdk/core/src/http_client/reqwest.rs Show resolved Hide resolved
sdk/core/src/http_client/reqwest.rs Outdated Show resolved Hide resolved
sdk/core/src/lib.rs Outdated Show resolved Hide resolved
sdk/data_tables/src/responses/submit_transaction_response.rs Outdated Show resolved Hide resolved
cataggar
cataggar commented Jun 27, 2022
View reviewed changes
sdk/core/src/response.rs Outdated Show resolved Hide resolved
@cataggar cataggar dismissed rylev’s stale review June 27, 2022 17:06

All requested changes have been made.

@cataggar cataggar merged commit 34ce004 into Azure:main Jun 27, 2022
@cataggar cataggar deleted the http branch June 27, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cataggar @rylev @ctaggart