migrate SDKs from http::Request to azure_core::Request
#833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataggar
changed the title
http:Request to azure_core::Request
ctaggart
changed the title
http:Request to azure_core::Requesthttp::Request to azure_core::Request
cataggar
changed the title
http::Request to azure_core::Requesthttp::Request to azure_core::Request
bmc-msft
reviewed
Jun 20, 2022
bmc-msft
reviewed
Jun 20, 2022
bmc-msft
reviewed
Jun 20, 2022
Co-authored-by: bmc-msft <[email protected]>
cataggar
reviewed
Jun 20, 2022
bmc-msft
reviewed
Jun 20, 2022
bmc-msft
reviewed
Jun 20, 2022
rylev
approved these changes
Jun 21, 2022
|
|
||
| let request = request.body("".to_owned())?; | ||
| request.set_body(""); |
There was a problem hiding this comment.
Do we need this? Is this not the default?
| common_storage_response_headers: headers.try_into()?, | ||
| etag: etag_from_headers(headers)?.into(), | ||
| location: headers | ||
| .get("location") |
There was a problem hiding this comment.
Suggested change
| .get("location") | |
| .get_as_parsed::<Url>::("location") |
There was a problem hiding this comment.
No get_as_parsed yet. Would be nice.
Closed
bmc-msft
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the migration from
http::Requesttoazure_core::Request. This should make moving to HTTP pipelines easier. Some highlights:execute_request_check_statusfunctionhttp::Response<Bytes>, it returns a newazure_core::CollectedResponsehttp:HeaderMapwithazure_core::headers::Headersget_as_stror_errvariants likeget_as_str_or_errhttp:request::Builderwith functions inazure_core::Request