Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: azure_core fails to build with azurite_workaround feature #824

Merged
merged 4 commits into from
Jun 17, 2022

Conversation

roeap
Copy link
Contributor

@roeap roeap commented Jun 17, 2022

This PR fixes a conflicting error definition left behind the azurite_workaround feature gate.

closes #823

@roeap roeap changed the title fix azure_core fails to build with azurite_workaround feature fix: azure_core fails to build with azurite_workaround feature Jun 17, 2022
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Can we add a run of cargo check --feature azurite_workaround to CI so that this won't happen again in the future?

@roeap
Copy link
Contributor Author

roeap commented Jun 17, 2022

@rylev - absolutely, and good thing we did, b/c there was another one hidden in the storage_blobs crate.

@bmc-msft bmc-msft requested a review from rylev June 17, 2022 13:13
@rylev rylev merged commit ea54831 into Azure:main Jun 17, 2022
@roeap roeap deleted the fix-azurite-workaroud branch June 17, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure_core fails to build with azurite_workaround feature
2 participants