-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate sdk/storage_blob to azure_core::error scheme #794
Migrate sdk/storage_blob to azure_core::error scheme #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hi Rick. Many thanks for this - looks great to me, so far... However, (unfortunately!) there are still quite a few more changes that need to be made for this crate. This crate not only has its own error definitions, but pulls in most of its error definitions from
If you change this to pull in the new-style error definitions from
|
@johnbatty, thanks for pointing that out. I was a little suspicious there weren't more changes. Following your guidance, I'm now seeing 90+ errors that need to be resolved. I'll work on this and ping you and @cataggar to re-review when I'm done. |
rickrain commented they have more work to do
Just realizing that the changes here are dependent on the work in #792. I think I have everything done except for what's in |
@rickrain I just had similar issues working on storage_queues. I decided to get it building independently with the existing (non-converted) storage crate using a map_kind(...) on the non-azure_core error(s) returned by storage. Here's an example from my storage_queues PR: self.storage_client
.queue_url_with_segments(Some(self.queue_name.as_str()).into_iter().chain(segments))
.map_kind(ErrorKind::DataConversion) If we can get the higher level storage crates building/merged, then we can merge the storage crate and have a pass through to clean up any unnecessary ErrorKind maps. |
@johnbatty, thanks a ton for that pointer. That helped a lot! |
@johnbatty, @cataggar This PR is ready for review. |
This PR migrates the sdk/storage_blob to the new azure_core::error scheme as described in #771.