[Storage] stage_block, commit_block_list for BlobClient, get_container_properties for ContainerClient, get_service_properties for ServiceClient
#2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenttran-msft
commented
Mar 4, 2025
Comment on lines
+135
to
+147
| // Currently blocked by generated code, uncomment when we can consume newest definition | ||
| // pub async fn get_block_list( | ||
| // &self, | ||
| // list_type: BlockListType, | ||
| // options: Option<BlobBlockBlobClientGetBlockListOptions<'_>>, | ||
| // ) -> Result<Response<BlockList>> { | ||
| // let response = self | ||
| // .client | ||
| // .get_blob_block_blob_client(self.container_name.clone(), self.blob_name.clone()) | ||
| // .get_block_list(list_type, options) | ||
| // .await?; | ||
| // Ok(response) | ||
| // } |
There was a problem hiding this comment.
This was fully working E2E against a forked copy of the generated code that contained the necessary fixes. This will be fixed when we can regenerate and get the necessary generated code changes (emitter currently is broken by newest .tsp definition).
Same comment applies to get_service_properties for BlobServiceClient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.