Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid manually managing query strings #1421

Merged

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Sep 27, 2023

SAS tokens are query strings and follow the encoding rules required by Url query strings. Hand crafting Url query strings could lead us into failure points in the future.

This also removes the need for the internal note to ourselves to address in the future:

// splitting by & is only safe if & is not part of any fields
// if that changes in the future we might want to use a proper query string parser

SAS tokens are query strings and follow the encoding rules required by Url query strings.  Hand crafting Url query strings could lead us into failure points in the future.
@demoray demoray merged commit 66008eb into Azure:main Sep 27, 2023
@demoray demoray deleted the avoid-manual-http-query-string-manipulation branch September 27, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants