Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address clippy warnings for azure_messaging_servicebus #1404

Merged
merged 1 commit into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions sdk/messaging_servicebus/src/service_bus/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,11 @@ fn finalize_request(
request.insert_header(headers::AUTHORIZATION, sas);

// get req body to return
match body {
Some(msg) => request.set_body(msg),
None => {
request.insert_header(headers::CONTENT_LENGTH, "0"); // added to avoid truncation errors
request.set_body(azure_core::EMPTY_BODY);
}
if let Some(body) = body {
request.set_body(body);
} else {
request.insert_header(headers::CONTENT_LENGTH, "0"); // added to avoid truncation errors
request.set_body(azure_core::EMPTY_BODY);
}

Ok(request)
Expand Down
11 changes: 4 additions & 7 deletions sdk/messaging_servicebus/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,9 @@ pub fn body_bytes_to_utf8(bytes: &[u8]) -> Result<String, Error> {
}

pub fn get_head_url(namespace: &str, queue_or_topic: &str, subscription: Option<&str>) -> String {
match subscription {
Some(sub) => format!(
"https://{namespace}.servicebus.windows.net/{queue_or_topic}/subscriptions/{sub}/messages/head"
),
None => format!(
"https://{namespace}.servicebus.windows.net/{queue_or_topic}/messages/head"
),
if let Some(sub) = subscription {
format!("https://{namespace}.servicebus.windows.net/{queue_or_topic}/subscriptions/{sub}/messages/head")
} else {
format!("https://{namespace}.servicebus.windows.net/{queue_or_topic}/messages/head")
}
}