Fix: BytesStream failing to set correct slice range

[dmweis]

BytesStream calls Bytes::slice with incorrect range of START..SIZE. Range should be START..END.

This results in incorrect slicing or even an assert failure of "range start must not be greater than end: coming from the slice methnod.

I wanted to add a test for this but don't see any tests for this code. If there are some I am happy to add a test for this case.

Tested locally from my fork

[dmweis]

Ah. Looks like the failures are because of new clippy version. Not because of my changes.

Should I create a separate PR to fix that?

[demoray]

#1203 should have already addressed the clippy issues. Can you rebase to the latest main?

[cataggar]

I'm curious what the impact is and how we get unit tests on it.

[johnbatty]

Fix looks good to me.

[johnbatty]

@dmweis I've written a few unit tests to provide some coverage of these functions (and which fail with the unmodified code/work with your fix). Are you happy for me to push these to your branch?

[dmweis]

@dmweis I've written a few unit tests to provide some coverage of these functions (and which fail with the unmodified code/work with your fix). Are you happy for me to push these to your branch?

Oh! That would be amazing! Please go ahead!

And my appologieze. I should have written tests. I forgot about this PR.

Happy to do any more work if there is anything else you'd like changed?

[johnbatty]

@dmweis Ok, I've added a few unit tests.
@demoray Please could you take another look.

[dmweis]

@microsoft-github-policy-service agree