update to latest specs #1090
Merged
update to latest specs #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you discuss your rational for stating we should ignore the readme when it specifies to use a preview version by default? Isn't this defined by the service owner? (or at least, the spec writer for the service?) |
It could mean a couple of things:
In either case, if there is a stable version, we should use it as our default. |
|
Here is a complete list. It makes sense that we default to the stable versions. There are 29. |
|
While I agree that logically a tag without prerelease in the name should be preferential to a tag with prerelease in the name, I believe this to be more complicated. Consider:
My thought is we probably want to follow the service specification author's specified version and open work items to track things that seem off. |
|
I changed it back, but made it a warning, so we can raise issues appropriately. |
bmc-msft
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a change to pick stable releases if available instead of a spec readme.md that specifies a preview version as the default. They should not be. I included unit tests.
check all features: https://github.com/ctaggart/azure-sdk-for-rust/actions/runs/3016729488