Move get_account_information
operation
#1056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite this change being relatively large in terms of number of lines of code changed, it's actually very simple. It's composed of two related changes (and the rest is just making the compiler happy):
StorageClient::get_account_information
was moved toBlobServiceClient
. This operation only has to do with the blob storage account and thus should not be on the more generalStorageClient
. It makes much more sense for it to be in theblob_storage
crate.core
module and theaccount
module. Theaccount
module only contained the code for theget_account_information
operation. Since this has moved to another crate, this module can be deleted which leaves thecore
module all alone. This PR removes the core module and moves all of its contents to the top level ofazure_storage
crate.Users will have to make two changes to their code:
StorageClient
to get blob storage account info, they'll need to use theBlobServiceClient
.azure_storage::core
, they'll need to just deletecore::
.This is the first step in a series of much bigger changes that @gorzell and I are doing together.