Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix formatting datetime for SAS generation #1033

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

bmc-msft
Copy link
Contributor

Azure uses RFC3339 format, except without microseconds/nanoseconds

Azure uses RFC3339 format, except without microseconds/nanoseconds
@bmc-msft
Copy link
Contributor Author

fixes #1032

@cataggar cataggar added the Storage Storage Service (Queues, Blobs, Files) label Aug 20, 2022
Copy link
Member

@cataggar cataggar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bmc-msft. Could you add a unit test? Something like the 2nd example:
https://docs.rs/time/latest/time/format_description/well_known/struct.Rfc3339.html

@bmc-msft bmc-msft linked an issue Aug 22, 2022 that may be closed by this pull request
@bmc-msft bmc-msft requested a review from rylev August 22, 2022 15:14
@rylev rylev merged commit 3b8cb3a into Azure:main Aug 22, 2022
@bmc-msft bmc-msft deleted the fix-datetime-format-sas branch August 22, 2022 16:59
@cataggar cataggar added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

converting from Chrono to Time broke SAS signatures
4 participants