Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that exchange is Send #1004

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Ensure that exchange is Send #1004

merged 2 commits into from
Aug 12, 2022

Conversation

satlank
Copy link
Contributor

@satlank satlank commented Aug 12, 2022

Shadowing the encoded Serializer makes it not send if the lifetime is
not restricted to end before the first await.

Shadowing the `encoded` Serializer makes it not send if the lifetime is
not restricted to end before the first `await`.
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we can clean up the code a bit more though.

sdk/identity/src/refresh_token.rs Outdated Show resolved Hide resolved
@rylev rylev merged commit 2969b66 into Azure:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants