Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default sdks to azure_core/enable_reqwest #1003

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

cataggar
Copy link
Member

Reported by @mario-guerra when using azure_messaging_servicebus 0.4.0. He had to explicitly set:

azure_core = { version = "0.4.0", features = ["enable_reqwest"] }

to avoid:

thread 'main' panicked at 'A request was called on the default http client NoopClient.This client does nothing but panic. Make sure to enable an httpclient that can actually perform requests. You can do this by ensuring that the reqwest feature is enabled.

The default in azure_core was changed 3 weeks ago while working on wasm in https://github.com/Azure/azure-sdk-for-rust/pull/939/files#diff-7635a0301d45857a3457ae111c5fc7a672bf63303f2693ed9fe6986271338d86R48 .

This sets the default of azure_core/enable_reqwest in:

  • azure_iot_hub
  • azure_messaging_eventgrid
  • azure_messaging_servicebus
  • azure_security_keyvault

@cataggar cataggar changed the title default sdks to azure_core/enable_reqwest default sdks to azure_core/enable_reqwest Aug 11, 2022
Copy link
Member

@mario-guerra mario-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rylev rylev merged commit a63710a into Azure:main Aug 12, 2022
@mario-guerra
Copy link
Member

@cataggar when will the crates affected by this change be updated?

@cataggar cataggar deleted the default-to-reqwest branch August 13, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants