Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interrupt audio and announce api. #38916

Merged
merged 6 commits into from
Dec 30, 2024

Conversation

v-pivamshi
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-communication-callautomation

Copy link
Contributor

@cochi2 cochi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It misses Unit Tests and the change to Play to include the interruptHoldAudio flag.

@v-vdharmaraj v-vdharmaraj marked this pull request as ready for review December 23, 2024 22:36
@v-vdharmaraj v-vdharmaraj enabled auto-merge (squash) December 30, 2024 19:11
@v-vdharmaraj v-vdharmaraj merged commit 5e2ca77 into main Dec 30, 2024
21 checks passed
@v-vdharmaraj v-vdharmaraj deleted the v-pivamshi/feature/interruptAudioAndAnnounce branch December 30, 2024 19:15
singankit pushed a commit that referenced this pull request Jan 14, 2025
* Added interrupt audio and announce api

* Added event validation in live test

* Added unit test

* updating the test

* fixing pylint errors

---------

Co-authored-by: Vinothini Dharmaraj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants