-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added interrupt audio and announce api. #38916
Merged
v-vdharmaraj
merged 6 commits into
main
from
v-pivamshi/feature/interruptAudioAndAnnounce
Dec 30, 2024
Merged
Added interrupt audio and announce api. #38916
v-vdharmaraj
merged 6 commits into
main
from
v-pivamshi/feature/interruptAudioAndAnnounce
Dec 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check APIView has identified API level changes in this PR and created following API reviews. |
...e-communication-callautomation/azure/communication/callautomation/_call_connection_client.py
Outdated
Show resolved
Hide resolved
cochi2
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It misses Unit Tests and the change to Play to include the interruptHoldAudio
flag.
v-vdharmaraj
approved these changes
Dec 24, 2024
minwoolee-msft
approved these changes
Dec 30, 2024
singankit
pushed a commit
that referenced
this pull request
Jan 14, 2025
* Added interrupt audio and announce api * Added event validation in live test * Added unit test * updating the test * fixing pylint errors --------- Co-authored-by: Vinothini Dharmaraj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines