Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python - pr #36635

Closed
wants to merge 132 commits into from
Closed

python - pr #36635

wants to merge 132 commits into from

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jul 25, 2024

This PR is the actual implementation of a expanding/contracting public pull request build.

python - pr will replace all existing python - <service> - ci builds in public.

To manually run the the python - pr build instead of for a PR, one can manually queue it and set the service to the package that should be scanned.

TODO:

  • Initial yml updates
  • Verify pull request conditions vs "auto" service directory argument
    • Do we need to be worried about pull request logic showing up if we /azp run a job? Should I pull back to only honor the auto instead of Build.Reason?
    • No. @weshaggard would prefer that the same expandable logic (including beyond their package directory) is possible. This is now in place.
    • We also need to change this such that ServiceDirectory targeted also build dependent packages.
  • Handle verify readme error
  • Ensure that verify changelog static analysis actually runs (notice it's all skipped currently)
  • Handle issues with detect api changes
  • Test an internal core invocation from a package, ensure that the expansion still works
  • Test a nightly livetest build to verify that nothing from previous methodology is broken -- check
  • Test template release build -- check
  • Test nightly scheduled build to verify package property updates

scbedd and others added 28 commits July 19, 2024 15:20
…y close to being ready to go. got a lot of simplifying to work through
@scbedd scbedd self-assigned this Jul 25, 2024
@scbedd scbedd requested a review from mccoyp as a code owner July 25, 2024 18:23
@scbedd scbedd requested a review from a team as a code owner August 30, 2024 21:25
@weshaggard
Copy link
Member

@scbedd when you think you are ready can you call a meeting with @benbp and I so we can do a live review of all the changes. I want to make sure we both fully understand these.

@scbedd scbedd closed this Sep 12, 2024
@scbedd
Copy link
Member Author

scbedd commented Sep 12, 2024

Closing to prevent pounding on the agent pool while I clean up python - pr from the latest updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants