Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding v2 #31457

Merged
merged 14 commits into from
Aug 23, 2023
Merged

Onboarding v2 #31457

merged 14 commits into from
Aug 23, 2023

Conversation

danieljurek
Copy link
Member

@danieljurek danieljurek commented Aug 3, 2023

Example docindex run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2992537&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739&t=9e8e3f45-1b4f-5a0b-f97c-ea625d97d635

Note: There's also a cleanup PR to cleanup older language specific items.

Example nightly service pipeline run (failure in Analyze job unrelated to this change): https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2981301&view=logs&s=cc1c0c38-0f79-5da2-c09f-847e3abdf9ce&j=f8e040b3-c0ff-5789-0eda-99daaaa3fc1b

Note: Key ordering in JSON outputs are not sorted because PowerShell did not use ordered hashtables for ConvertFrom-Json -AsHashtable until PowerShell 7.3 and the agent is using 7.2. For example, this commit changes no package onboarding information but does alter the ordering of keys: MicrosoftDocs/azure-docs-sdk-python@7f0f9cf ... Until PowerShell is upgraded on the agent this will continue to be the case. Array ordering is not affected.

@danieljurek danieljurek force-pushed the djurek/docs-onboarding-2 branch from 3e02a5a to 06d1143 Compare August 4, 2023 13:18
@danieljurek danieljurek self-assigned this Aug 10, 2023
@danieljurek danieljurek marked this pull request as ready for review August 14, 2023 04:28
@JimSuplizio JimSuplizio self-requested a review August 17, 2023 22:55
Copy link
Member

@JimSuplizio JimSuplizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our discussion, I'm good with these changes.

@danieljurek danieljurek merged commit 4e4d430 into main Aug 23, 2023
@danieljurek danieljurek deleted the djurek/docs-onboarding-2 branch August 23, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants