Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NetAppFiles to 2022-05-01 #26333

Merged
merged 7 commits into from
Sep 26, 2022
Merged

Conversation

hildurhodd
Copy link
Contributor

Description

This is a copy of #26260 with new recordings

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

PythonSdkPipelines and others added 2 commits September 16, 2022 01:09
* Update swagger_to_sdk_config_dpg.json

* Update swagger_to_sdk_config_autorest.json
@hildurhodd hildurhodd force-pushed the update-netapp-2022-05-01 branch from 43038f8 to 866e4eb Compare September 20, 2022 15:25
@msyyc
Copy link
Member

msyyc commented Sep 21, 2022

@hildurhodd Why did you change the configuration? Please keep it same with main branch
image
image

@hildurhodd
Copy link
Contributor Author

@hildurhodd Why did you change the configuration? Please keep it same with main branch image image

I noticed after I created the pull request that this was different than in the original PR so I reverted it. It should be the same https://github.com/Azure/azure-sdk-for-python/pull/26260/files

@hildurhodd
Copy link
Contributor Author

@msyyc I have removed the blank line and the autorest version in the same as main. Can we get this moving?

@msyyc
Copy link
Member

msyyc commented Sep 26, 2022

/check-enforcer override

@msyyc msyyc force-pushed the update-netapp-2022-05-01 branch from 69306cd to 4cfe26a Compare September 26, 2022 03:01
@msyyc msyyc merged commit 17cf690 into Azure:main Sep 26, 2022
@hildurhodd hildurhodd deleted the update-netapp-2022-05-01 branch September 26, 2022 08:37
@msyyc
Copy link
Member

msyyc commented Sep 26, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants