This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Allow firebase/jwt to be installed in version 5.0 and above #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-shandar
approved these changes
Jan 16, 2018
|
Hey @sergey-shandar - thanks for the merge. Could you tag that commit as a new release (e.g. 0.5.8) so users of the SDK can safely reference this within their composer.json files? Additionally, #953 could be closed as in that issue the author asks for an update to firebase-jwt >= 5.0. |
|
@sergey-shandar As above, please publish a new release. This was merged over 2 years ago but without tagging a new release I still can't install due to composer dependancy conflicts. |
|
Is there a new release for this? |
|
There doesn't seem to be a release available on packagist for this yet? |
|
@vinjiang: Pinging another Azure PHP developer - this package doesn't seem to be maintained anymore, do you know what the status is? |
Roman77450
pushed a commit
to myQaa/azure-sdk-for-php
that referenced
this pull request
Jul 9, 2021
…besides version 4.0 and above (Azure#961)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firebase/jwt's versioning scheme isn't ideal. However, version 5.0.0 bas been released on 2017-06-27. I've updated the composer.json to allow version 5.0.0 (and above) or version 4.0.0 (and above). Version requirement '^4.0' made it impossible to install the Azure SDK for PHP in projects that already required firebase/jwt in version '^>=5.0' in their own composer.json.