Removing the HTTP_Request2 package. #894
Conversation
…r' into sergey-shandar-pear2
…r' into sergey-shandar-pear2 # Conflicts: # composer.lock
…r' into sergey-shandar-pear2
…r' into sergey-shandar-pear2
…r' into sergey-shandar-pear2
…r' into sergey-shandar-pear2
…-sdk-for-php into sergey-shandar-pear2
|
Partly #797 |
|
Can one of the admins verify this patch? |
| * @param IHttpClient $request HTTP channel object. | ||
| * @param \HTTP_Request2_Response $response HTTP response object. | ||
| * @param IHttpClient $request HTTP channel object. | ||
| * @param ResponseInterface $response HTTP response object. |
There was a problem hiding this comment.
why don't you use IHttpResponse instead? that will be more consistent
There was a problem hiding this comment.
Ignore this if the definition is from Guzzle.
There was a problem hiding this comment.
ResponseInterface is defined in PSR 7 http://www.php-fig.org/psr/psr-7/ and it has all functionality that we need. I don't see a point to create a wrap on top of it. But we may wrap in the future if we have a good reason for it.
| @@ -25,7 +25,8 @@ | |||
|
|
|||
| namespace Tests\framework; | |||
There was a problem hiding this comment.
No need to fix the storage test files. You can just get rid of them.
There was a problem hiding this comment.
I will :-) May be in next PR.
|
also, I would prefer to squash the commits since you have 93 of them on this branch. |
|
NP. I can squash it because I don't have branches which depends on this one. |
No description provided.