Fix namespaces generation to handle framework targets other than netstandard2.0 #44768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
reviewed
Jun 27, 2024
weshaggard
reviewed
Jun 27, 2024
weshaggard
approved these changes
Jun 27, 2024
tejasm-microsoft
pushed a commit
to tejasm-microsoft/azure-sdk-for-net
that referenced
this pull request
Jul 22, 2024
…tandard2.0 (Azure#44768) * Fix namespaces generation to handle framework targets other than netstandard2.0 * fix variable name * If more than 1 is found, just use the first one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace generation was looking for the built dll in the netstandard2.0 subdirectory. Turns out this wasn't correct if the framework target wasn't netstandard2.0, as discovered by the net - webpubsub - ci pipeline
Instead of computing the full directory where the dll, which would be the framework target directory, go one level up and do a search for the .dll.