Add Convenience Types to System.ClientModel library #41016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del-convenience-types
annelo-msft
requested review from
KrzysztofCwalina,
tg-msft,
JoshLove-msft and
christothes
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
commented
Jan 4, 2024
annelo-msft
commented
Jan 4, 2024
annelo-msft
commented
Jan 4, 2024
sdk/core/System.ClientModel/src/Convenience/ClientResultException.cs
Outdated
Show resolved
Hide resolved
annelo-msft
commented
Jan 4, 2024
sdk/core/System.ClientModel/src/Convenience/ClientResultException.cs
Outdated
Show resolved
Hide resolved
annelo-msft
commented
Jan 4, 2024
annelo-msft
commented
Jan 5, 2024
This was referenced Jan 5, 2024
annelo-msft
commented
Jan 5, 2024
christothes
reviewed
Jan 5, 2024
sdk/core/System.ClientModel/src/Convenience/OptionalClientResultOfT.cs
Outdated
Show resolved
Hide resolved
jsquire
reviewed
Jan 5, 2024
sdk/core/System.ClientModel/src/Convenience/ClientResultException.cs
Outdated
Show resolved
Hide resolved
christothes
reviewed
Jan 8, 2024
christothes
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add types in the System.ClientModel namespace -- i.e. those for end-users of ClientModel clients -- to System.ClientModel library. This includes:
ClientResult,ClientResult<T>andOptionalClientResult<T>KeyCredentialClientRequestExceptionIt also includes
PipelineResponse, which is needed to support most of these types.A discussion of the types contained in this PR can be found in the System.ClientModel README.