[AzureMonitorDistro] use IConfiguration to set ConnectionString #37999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
requested review from
cijothomas,
reyang,
rajkumar-rangaraj and
vishweshbankwar
as code owners
rajkumar-rangaraj
requested changes
Aug 2, 2023
You beat me to it :) We documented that EnvVar should take precedence. I just added more tests for this scenario |
There is no guarantee that Environment Variables are part of IConfiguration, please review the feedback in previous feedback. |
|
API change check API changes are not detected in this pull request. |
cijothomas
reviewed
Aug 3, 2023
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/DefaultAzureMonitorOptions.cs
Outdated
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #37913 (comment).
Changes