Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set otel.status_code #22115

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Always set otel.status_code #22115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/core/Azure.Core/src/Pipeline/Internal/RequestActivityPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ private async ValueTask ProcessAsync(HttpMessage message, ReadOnlyMemory<HttpPip
{
activity.AddTag("otel.status_code", "ERROR");
}
else
{
// Set the status to UNSET so the AppInsights doesn't try to infer it from the status code
activity.AddTag("otel.status_code", "UNSET");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is otel.status_code supported by appInsights SDK to populate success? It looks like only EventHub listener is aware of it

Copy link
Contributor Author

@pakrym pakrym Jun 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the listener you linked (https://github.com/microsoft/ApplicationInsights-dotnet/blob/53a4422d01dbd068baaaeecc1ee9f2fb74fc82e9/WEB/Src/DependencyCollector/DependencyCollector/Implementation/AzureSdk/AzureSdkDiagnosticsEventHandler.cs) is used for all azure SDK activities including HTTP.

}
}
finally
{
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/Azure.Core/tests/RequestActivityPolicyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ public async Task ActivityIsCreatedForRequest()
CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("http.user_agent", "agent"));
CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("requestId", clientRequestId));
CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("serviceRequestId", "server request id"));
CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("otel.status_code", "UNSET"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test that validates it being set to "ERROR"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have one https://github.com/pakrym/azure-sdk-for-net/blob/pakrym/Always-set-otel-status_code/sdk/core/Azure.Core/tests/RequestActivityPolicyTests.cs#L87

CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("kind", "client"));
CollectionAssert.Contains(activity.Tags, new KeyValuePair<string, string>("az.namespace", "Microsoft.Azure.Core.Cool.Tests"));
CollectionAssert.DoesNotContain(activity.Tags.Select(t=>t.Key), "otel.status_code");
}

[Test]
Expand Down