cleanup todos (#37913)

sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/DefaultAzureMonitorOptions.cs

@@ -31,6 +31,7 @@ public void Configure(AzureMonitorOptions options)
 
             try
             {
+                // TODO: should we replace this with IConfiguration?
                 string connectionString = Environment.GetEnvironmentVariable(ConnectionStringEnvironmentVariable);
 
                 if (!string.IsNullOrWhiteSpace(connectionString))

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/ArrayExtensions.cs

@@ -27,7 +27,6 @@ internal static class ArrayExtensions
             StringBuilder sb = new(input.Length);
             foreach (var item in input)
             {
-                // TODO: Consider changing it to JSon array.
                 if (item != null)
                 {
                     sb.Append(item);

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/AzureMonitorTransmitter.cs

@@ -121,10 +121,7 @@ private static ApplicationInsightsRestClient InitializeRestClient(AzureMonitorEx
                 }
                 catch (Exception ex)
                 {
-                    // TODO:
-                    // Remove this when we add an option to disable offline storage.
-                    // So if someone opts in for storage and we cannot initialize, we can throw.
-                    // Change needed on persistent storage side to throw if not able to create storage directory.
+                    // TODO: Should we throw if customer has opted for storage?
                     AzureMonitorExporterEventSource.Log.FailedToInitializePersistentStorage(connectionVars.InstrumentationKey, ex);
 
                     return null;

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/ResourceExtensions.cs

@@ -77,6 +77,7 @@ internal static class ResourceExtensions
         }
 
         // TODO: Check if service.name as unknown_service should be sent.
+        // (2023-07) we need to drop the "unknown_service."
         if (serviceName != null && serviceNamespace != null)
         {
             azureMonitorResource.RoleName = string.Concat(serviceNamespace, "/", serviceName);

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/StandardMetricsExtractionProcessor.cs

@@ -60,6 +60,7 @@ public override void OnEnd(Activity activity)
             }
 
             // TODO: other activity kinds
+            // (2023-07) fix before GA
         }
 
         private void ReportRequestDurationMetric(Activity activity)

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/Statsbeat/AzureMonitorStatsbeat.cs

@@ -61,8 +61,6 @@ internal AzureMonitorStatsbeat(ConnectionVars connectionStringVars, IPlatform pl
 
             // Configure for attach statsbeat which has collection
             // schedule of 24 hrs == 86400000 milliseconds.
-            // TODO: Follow up in spec to confirm the behavior
-            // in case if the app exits before 24hrs duration.
             var exporterOptions = new AzureMonitorExporterOptions
             {
                 DisableOfflineStorage = true,

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Tests/E2ETelemetryItemValidation/TracesTests.cs

@@ -169,7 +169,7 @@ public void VerifyExceptionWithinActivity()
             // ASSERT
             Assert.True(telemetryItems.Any(), "Unit test failed to collect telemetry.");
             this.telemetryOutput.Write(telemetryItems);
-            var activityTelemetryItem = telemetryItems.First(x => x.Name == "RemoteDependency"); // TODO: Change to Single(). Still investigating random duplicate export which only reproduces on build server.
+            var activityTelemetryItem = telemetryItems.First(x => x.Name == "RemoteDependency");
 
             TelemetryItemValidationHelper.AssertActivity_As_DependencyTelemetry(
                 telemetryItem: activityTelemetryItem,