Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[search] Updates for preview 1 #7641

Merged
merged 20 commits into from
Mar 7, 2020
Merged

[search] Updates for preview 1 #7641

merged 20 commits into from
Mar 7, 2020

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Mar 3, 2020 •
edited
Loading

Guidance from the product team was to set an Accept header so that OData metadata wouldn't be returned on responses. Added a policy to the client to set this header correctly.

Other changes:

  • Small typings fixes
  • README updates
  • Version change
  • Add a simple readonly sample
  • Make orderBy a collection
  • Renamed listSearchResults to search and changed the return type to promote page metadata

@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Search labels Mar 3, 2020
@xirzec xirzec requested a review from ramya-rao-a as a code owner March 3, 2020 23:46
@xirzec xirzec self-assigned this Mar 3, 2020
@xirzec xirzec changed the title [search] Remove OData metadata from responses [search] Updates for preview 1 Mar 4, 2020
@xirzec
Copy link
Member Author

xirzec commented Mar 6, 2020

@bterlson this should be complete for preview1 changes. Please take one last look (especially at the api surface)

@xirzec xirzec added this to the [2020] March milestone Mar 6, 2020
@xirzec xirzec requested a review from brjohnstmsft March 6, 2020 01:45
brjohnstmsft
brjohnstmsft suggested changes Mar 6, 2020
View reviewed changes
@xirzec xirzec requested a review from brjohnstmsft March 6, 2020 19:23
brjohnstmsft
brjohnstmsft approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation details are lost on me, but the API looks good :)

@xirzec xirzec mentioned this pull request Mar 6, 2020
Closed
@xirzec xirzec merged commit 6bbed0d into Azure:master Mar 7, 2020
@xirzec xirzec deleted the searchUpdates branch March 7, 2020 03:11
@xirzec xirzec linked an issue Mar 9, 2020 that may be closed by this pull request
[Cognitive Search] Create samples and snippets #7187
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bterlson bterlson bterlson approved these changes

@brjohnstmsft brjohnstmsft brjohnstmsft approved these changes

@willmtemple willmtemple Awaiting requested review from willmtemple

@chradek chradek Awaiting requested review from chradek

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

Assignees

@xirzec xirzec

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] March
Development

Successfully merging this pull request may close these issues.

[Cognitive Search] Create samples and snippets
3 participants
@xirzec @bterlson @brjohnstmsft