Event Hubs & Service Bus to use latest version of core-amqp & amqp-common #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
requested review from
bterlson,
ramya-rao-a and
ramya0820
as code owners
|
/azp run js - eventhubs-client - tests |
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
richardpark-msft
approved these changes
Dec 11, 2019
|
Yes, that's pretty much it. |
ramya-rao-a
approved these changes
Dec 11, 2019
ramya-rao-a
changed the title
|
Saw one known test error in event hubs that's tracked by #6437. If the service bus tests pass I'll merge. |
bterlson
approved these changes
Dec 12, 2019
ramya-rao-a
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6118
@azure/[email protected]includes this fix. This updates the preview version of@azure/event-hubsand@azure/service-busto depend on the version of their core amqp libraries that has a 1 minute idle timeout.