[event-hubs](2.x) appends a unique id to user-provided receive name #6506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Dec 11, 2019
|
|
||
| should.equal(receiverNames.size, partitionIds.length, "Unexpected number of receiver names found."); | ||
|
|
||
| // wait for all receivers to be open before stopping them. |
There was a problem hiding this comment.
why wait? why not add an afterEach that closes the client?
There was a problem hiding this comment.
I found a possible bug in our library (will log an issue). If I call stop on the receiveHandler before the cbs link has been established, then client.close will throw an error because it attempts to call close on the link that doesn't yet exist.
ramya-rao-a
approved these changes
Dec 12, 2019
|
Test failures are expected since the iothub connection string format has changed between version 2.x and 5.x of event hubs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6378