Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set implicitlyPreferredVersions=false #6290

Merged
merged 7 commits into from
Nov 21, 2019
Merged

Set implicitlyPreferredVersions=false #6290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8a17970
Set implicitlyPreferredVersions=false
mikeharder Nov 9, 2019
5949681
Remove rhea-promise from preferredVersions
mikeharder Nov 9, 2019
6344130
Set strictPeerDependencies=true
mikeharder Nov 9, 2019
1992614
Update pnpm-lock.yaml (full)
mikeharder Nov 21, 2019
408c04e
Remove comment
mikeharder Nov 21, 2019
5e878e8
Add comment
mikeharder Nov 21, 2019
5bd6ad4
Revert accidental whitespace change
mikeharder Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions common/config/rush/common-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,20 @@
* instead of the latest version.
*/
// "some-library": "1.2.3"

// This is required to allow for backward compatibility with Service Bus Track 1
// Workaround for microsoft/web-build-tools#1415
// TODO: Remove this once Service Bus is updated to use current depenedencies as part of Track 2
"rhea-promise": "^0.1.15"
},
/**
* When set to true, for all projects in the repo, all dependencies will be automatically added as preferredVersions,
* except in cases where different projects specify different version ranges for a given dependency. For older
* package managers, this tended to reduce duplication of indirect dependencies. However, it can sometimes cause
* trouble for indirect dependencies with incompatible peerDependencies ranges.
*
* The default value is true. If you're encountering installation errors related to peer dependencies,
* it's recommended to set this to false.
*
* After modifying this field, it's recommended to run "rush update --full" so that the package manager
* will recalculate all version selections.
*/
"implicitlyPreferredVersions": false,
/**
* The "rush check" command can be used to enforce that every project in the repo must specify
* the same SemVer range for a given dependency. However, sometimes exceptions are needed.
Expand Down
Loading