Fix dev build script to update dependencies acc to semver #6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaGhiya
requested review from
mikeharder and
mitchdenny
as code owners
weshaggard
reviewed
Nov 12, 2019
|
@danieljurek @weshaggard This PR is ready for review and made all requested changes discussed offline |
danieljurek
approved these changes
Nov 13, 2019
eng/tools/versioning/set-dev.js
Outdated
|
|
||
| // Update any references to internal projects with the new versions | ||
| for (const package of Object.keys(rushPackages)) { | ||
| if ( |
There was a problem hiding this comment.
This filter is being executed twice. We can execute it once saving lines of code and making it so that future logic changes only have to edit one version of the filter logic.
let targetPackages = [];
for (const package of Object.keys(rushPackages)) {
if (
["client", "core"].includes(rushPackages[package].versionPolicy)
&& rushPackages[package].projectFolder.startsWith(`sdk/${service}`)
) {
targetPackages.push(package);
}
}
for (const package of targetPackages)) {
console.log("package updated = ");
console.log(package);
rushPackages = updatePackageVersion(rushPackages, package, buildId);
console.log(rushPackages[package].newVer);
}
...
|
@weshaggard The issue comes with js-core pipeline if i only update the dependencies of the packages we want to ship then we get mismatching dependencies in case the packages are dependent amongst themselves - I think we need to update the packages that are depndent on the packages we build as well Starting "rush update" @azure/core-asynciterator-polyfill
@azure/core-http
@azure/core-tracing
@azure/abort-controller
@azure/core-arm
@azure/core-auth
@azure/identity
@azure/logger
Found 8 mis-matching dependencies! |
KarishmaGhiya
force-pushed
the
fixDevBuildScript
branch
from
8074412 to
5080a2a
Compare
weshaggard
reviewed
Nov 15, 2019
weshaggard
reviewed
Nov 15, 2019
weshaggard
reviewed
Nov 15, 2019
weshaggard
reviewed
Nov 15, 2019
weshaggard
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined both Daniel's script and the script from PR - #5135 commit