Add new @azure/app-configuration library #4753
Conversation
|
|
||
| ### Currently supported environments | ||
|
|
||
| - Node.js version 6.x.x or higher |
There was a problem hiding this comment.
Is the README configurable at all through autorest? I think we're now saying we only support version 8.x.x or higher, and should be using @azure/identity over @azure/ms-rest-nodeauth if possible.
Since this package also includes the convenience layer we should probably make these changes (though they can probably be done in a separate PR to get this base out), but will it get replaced if we need to regenerate from the models again?
There was a problem hiding this comment.
When generating code, there is an option to skip the readme
| "prepack": "npm install && npm run build" | ||
| }, | ||
| "sideEffects": false, | ||
| "autoPublish": true |
There was a problem hiding this comment.
Do we want auto publishing? I believe this means when a PR with a version change is merged, it gets auto published
There was a problem hiding this comment.
Nope, will remove it.
|
|
||
| const ConnectionStringRegex = /Endpoint=(.*);Id=(.*);Secret=(.*)/; | ||
| const deserializationContentTypes = { | ||
| json: ["application/vnd.microsoft.appconfig.kvset+json"] |
There was a problem hiding this comment.
I was testing the operations and found there are actually more content types than this we need to add!
Source: https://github.com/Azure/AppConfiguration/blob/master/docs/REST/kv.md
- application/vnd.microsoft.appconfig.kv+json
- application/vnd.microsoft.appconfig.kvs+json
- application/problem+json
Source: https://github.com/Azure/AppConfiguration/blob/master/docs/REST/keys.md
- application/vnd.microsoft.appconfig.keyset+json
Source: https://github.com/Azure/AppConfiguration/blob/master/docs/REST/revisions.md
- application/vnd.microsoft.appconfig.revs+json
There was a problem hiding this comment.
Oh joy! Glad you caught those. In the future we may need to consider enabling regexes or wildcards in deserializationContentTypes so that we can say something like /application/.*+json/.
daviwil
changed the title
This PR adds a new
@azure/app-configurationlibrary that is a client for the Azure App Configuration service. It is partially generated from an unpublished Swagger spec.@ramya-rao-a: I've added a starting point for the convenience layer in
src/index.ts, all of the nicer API methods should go there.