-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] Update @azure/identity dependencies to use caret versions #4674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably need to run rush update --full
to update pnpm-lock.yaml
. I think we need the pnpm-lock.yaml
updates for this change to have impact.
sdk/identity/identity/package.json
Outdated
@@ -83,7 +83,7 @@ | |||
"@types/jws": "~3.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also float this
Argh, thanks! I'll have to remember to run it like that every time it doesn't get updated when I expect it to. |
373afa9
to
fb5d2c8
Compare
Strange build failure due to dependency upgrades, I'm looking into it. |
fb5d2c8
to
cbd3325
Compare
@daviwil The Verify Readme step in the pipeline failed because the Readme content in /sdk/appconfiguration/app-configuration/README.md doesn't match the required guidelines for Readme. Has some missing headers. You can follow the steps to fix it here - aka.ms/azure-sdk-analyze-failed |
Ouch, sorry about that! Thanks for letting me know. |
cbd3325
to
afc820c
Compare
Surprisingly there were no
pnpm-lock.yaml
updates after making these changes.Fixes #4673.