Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Update @azure/identity dependencies to use caret versions #4674

Merged
merged 1 commit into from
Aug 16, 2019

Conversation

daviwil
Copy link
Contributor

@daviwil daviwil commented Aug 5, 2019

Surprisingly there were no pnpm-lock.yaml updates after making these changes.

Fixes #4673.

@daviwil daviwil requested a review from mikeharder August 5, 2019 23:03
@daviwil daviwil requested a review from sophiajt as a code owner August 5, 2019 23:03
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to run rush update --full to update pnpm-lock.yaml. I think we need the pnpm-lock.yaml updates for this change to have impact.

@@ -83,7 +83,7 @@
"@types/jws": "~3.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also float this

@daviwil
Copy link
Contributor Author

daviwil commented Aug 5, 2019

Argh, thanks! I'll have to remember to run it like that every time it doesn't get updated when I expect it to.

@daviwil daviwil force-pushed the fix-identity-deps branch from 373afa9 to fb5d2c8 Compare August 5, 2019 23:12
@daviwil
Copy link
Contributor Author

daviwil commented Aug 5, 2019

Strange build failure due to dependency upgrades, I'm looking into it.

@KarishmaGhiya
Copy link
Member

KarishmaGhiya commented Aug 16, 2019

@daviwil The Verify Readme step in the pipeline failed because the Readme content in /sdk/appconfiguration/app-configuration/README.md doesn't match the required guidelines for Readme. Has some missing headers. You can follow the steps to fix it here - aka.ms/azure-sdk-analyze-failed

@daviwil
Copy link
Contributor Author

daviwil commented Aug 16, 2019

Ouch, sorry about that! Thanks for letting me know.

@daviwil daviwil force-pushed the fix-identity-deps branch from cbd3325 to afc820c Compare August 16, 2019 22:20
@daviwil daviwil merged commit 795ebf8 into Azure:master Aug 16, 2019
@daviwil daviwil deleted the fix-identity-deps branch August 16, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Identity] Float all dependencies
4 participants