[Storage] Azure Storage SDK 2018-11-09 Feature Release

.github/CODEOWNERS

@@ -15,7 +15,7 @@
 # /sdk/eventhub/
 # /sdk/identity/
 # /sdk/keyvault/
-/sdk/storage/ @XiaoningLiu @jeremymeng @HarshaNalluru
+/sdk/storage/ @XiaoningLiu @jeremymeng @HarshaNalluru @vinjiang @jiacfan
 
 # Management Plane
 /**/*Management*.ts @yaohaizh

common/config/rush/common-versions.json

@@ -4,7 +4,6 @@
  */
 {
   "$schema": "https://developer.microsoft.com/json-schemas/rush/v5/common-versions.schema.json",
-
   /**
    * A table that specifies a "preferred version" for a dependency package. The "preferred version"
    * is typically used to hold an indirect dependency back to a specific version, however generally
@@ -18,7 +17,6 @@
      */
     // "some-library": "1.2.3"
   },
-
   /**
    * The "rush check" command can be used to enforce that every project in the repo must specify
    * the same SemVer range for a given dependency.  However, sometimes exceptions are needed.
@@ -30,6 +28,9 @@
    * This design avoids unnecessary churn in this file.
    */
   "allowedAlternativeVersions": {
+    "@azure/ms-rest-js": [
+      "^2.0.0"
+    ]
     /**
      * For example, allow some projects to use an older TypeScript compiler
      * (in addition to whatever "usual" version is being used by other projects in the repo):

sdk/storage/CONTRIBUTING.md

@@ -67,6 +67,22 @@ npm run test:browser
 
 Browser testing is based on Karma, you can change default testing browser by modifying karma.conf.js file.
 
+### Record & Play
+
+By default, above test commands are live testing against real Azure Storage accounts. Before running above tests, set environment value `TEST_MODE` to switch to offline mock test mode or test recording mode.
+
+Playback mode is for offline mock test, which doesn't require a storage account, it's quick but less coverage:
+
+`export TEST_MODE=playback`
+
+Record tests for next playback. Recording is necessary adding or updating test cases:
+
+`export TEST_MODE=record`
+
+Live tests by clearing `TEST_MODE` environment variable:
+
+`export TEST_MODE=`
+
 ### Testing Features
 
 As you develop a feature, you'll need to write tests to ensure quality. You should also run existing tests related to your change to address any unexpected breaks in both Node.js and Browsers.

sdk/storage/storage-blob/ChangeLog.md

@@ -1,7 +1,24 @@
 # Changelog
 
+2019.07 10.4.0
+
+* Updated Azure Storage Service API version to [2018-11-09](https://docs.microsoft.com/en-us/rest/api/storageservices/version-2018-11-09).
 * Improved comments for `BlockBlobURL.upload()`.
 * Exported `HttpRequestBody` type for who wants to implement a customized HTTP client.
+* Fixed a bug of `downloadBlobToBuffer()` and `downloadAzureFileToBuffer()` when provided offset is not 0.
+* Fixed a bug that `Aborter` cannot work during retry interval.
+* Fixed a bug that `Aborter` throws timeout error even though it succeeds of `BlockBlobUrl.download()`.
+* Fixed a bug that "err.code.toUpperCase is not a function" when retries in browser.
+* Export `RetryPolicyType`.
+* `Aborter` doesn't require `dom` as tsconfig lib requirement anymore for `Event` type.
+* Service SAS generation now supports snapshot access control from 2018-11-09 in `generateBlobSASQueryParameters()`.
+* Service SAS generation now supports snapshot access control from API version 2018-11-09 in `generateBlobSASQueryParameters()`.
+* A new API `PageBlobURL.uploadPagesFromURL()` allows pages in a page blob to be written using a range of another blob as a source. This permits synchronous server-side copies to be orchestrated for page blobs of any size.
+* A new API `AppendBlobURL.appendBlockFromURL()` commits a new block of data to the end of an append blob. Method uses a range of another blob as a source. This permits synchronous server-side copies to be orchestrated for append blobs of any size.
+* A new API `BlobURL.syncCopyFromURL()` allows a block blob to be copied synchronously using a URL as a source. This API has a maximum size of 256 MB and preserves metadata and block list.
+* A new API `ServiceURL.getUserDelegationKey()` added to get a key that can be used to generate a user delegation SAS (shared access signature).
+* Updated HTTP client from axios to node-fetch in Node.js runtime.
+* A new option `keepAliveOptions` added to parameter of `StorageURL.newPipeline()` which controls keep-alive configurations. Keep-alive is enabled by default.
 
 2018.12 10.3.0
 

sdk/storage/storage-blob/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@azure/storage-blob",
   "sdk-type": "client",
-  "version": "10.3.0",
+  "version": "10.4.0",
   "description": "Microsoft Azure Storage SDK for JavaScript - Blob",
   "main": "./dist/index.js",
   "module": "./dist-esm/src/index.js",
@@ -19,7 +19,7 @@
   },
   "scripts": {
     "audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",
-    "build:autorest": "autorest ./swagger/README.md --typescript [email protected]/autorest.typescript@2.1.3",
+    "build:autorest": "autorest ./swagger/README.md --typescript [email protected]/autorest.typescript@4.1.1",
     "build:browserzip": "gulp zip",
     "build:es6": "tsc -p tsconfig.json",
     "build:nodebrowser": "rollup -c 2>&1",
@@ -74,7 +74,7 @@
   "homepage": "https://github.com/Azure/azure-sdk-for-js#readme",
   "sideEffects": false,
   "dependencies": {
-    "@azure/ms-rest-js": "^1.2.6",
+    "@azure/ms-rest-js": "^2.0.0",
     "events": "^3.0.0",
     "tslib": "^1.9.3"
   },

sdk/storage/storage-blob/recordings/browsers/aborter/recording_should_not_abort_after_calling_abort.json

@@ -2,25 +2,25 @@
  "recordings": [
   {
    "method": "PUT",
-   "url": "https://fakestorageaccount.blob.core.windows.net/container156058697809306189",
+   "url": "https://fakestorageaccount.blob.core.windows.net/container156404691376603837",
    "query": {
     "restype": "container"
    },
    "requestBody": null,
    "status": 201,
    "response": "",
    "responseHeaders": {
-    "date": "Sat, 15 Jun 2019 08:22:57 GMT",
-    "last-modified": "Sat, 15 Jun 2019 08:22:58 GMT",
+    "date": "Thu, 25 Jul 2019 09:24:55 GMT",
+    "last-modified": "Thu, 25 Jul 2019 09:24:55 GMT",
     "server": "Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0",
-    "etag": "\"0x8D6F16AAC77E5A4\"",
-    "x-ms-request-id": "9567147c-201e-0039-5053-233a35000000",
-    "x-ms-version": "2018-03-28",
+    "etag": "\"0x8D710E1F4EE47A0\"",
+    "x-ms-request-id": "d494aae0-c01e-0075-17ca-42b92d000000",
+    "x-ms-version": "2018-11-09",
     "content-length": "0"
    }
   }
  ],
  "uniqueTestInfo": {
-  "container": "container156058697809306189"
+  "container": "container156404691376603837"
  }
 }

sdk/storage/storage-blob/recordings/browsers/aborter/recording_should_not_abort_when_calling_abort_after_request_finishes.json

@@ -2,25 +2,25 @@
  "recordings": [
   {
    "method": "PUT",
-   "url": "https://fakestorageaccount.blob.core.windows.net/container156058697901900409",
+   "url": "https://fakestorageaccount.blob.core.windows.net/container156404691415106119",
    "query": {
     "restype": "container"
    },
    "requestBody": null,
    "status": 201,
    "response": "",
    "responseHeaders": {
-    "date": "Sat, 15 Jun 2019 08:22:58 GMT",
-    "last-modified": "Sat, 15 Jun 2019 08:22:58 GMT",
+    "date": "Thu, 25 Jul 2019 09:24:55 GMT",
+    "last-modified": "Thu, 25 Jul 2019 09:24:56 GMT",
     "server": "Windows-Azure-Blob/1.0 Microsoft-HTTPAPI/2.0",
-    "etag": "\"0x8D6F16AAC978151\"",
-    "x-ms-request-id": "9567151f-201e-0039-6753-233a35000000",
-    "x-ms-version": "2018-03-28",
+    "etag": "\"0x8D710E1F505A468\"",
+    "x-ms-request-id": "d494ab49-c01e-0075-62ca-42b92d000000",
+    "x-ms-version": "2018-11-09",
     "content-length": "0"
    }
   }
  ],
  "uniqueTestInfo": {
-  "container": "container156058697901900409"
+  "container": "container156404691415106119"
  }
 }

sdk/storage/storage-blob/recordings/browsers/aborter/recording_should_set_value_and_get_value_successfully.json

@@ -1,6 +1,6 @@
 {
  "recordings": [],
  "uniqueTestInfo": {
-  "container": "container156058697808401937"
+  "container": "container156404691375200388"
  }
 }