Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] [Service Bus] Update documentation for AAD setup #4393

Merged
merged 11 commits into from
Jul 23, 2019

Conversation

ramya0820
Copy link
Member

For more context refer to #3673

@ramya0820 ramya0820 self-assigned this Jul 23, 2019
@ramya-rao-a ramya-rao-a requested review from ShivangiReja and removed request for ramya-rao-a July 23, 2019 03:17
Copy link
Member

@HarshaNalluru HarshaNalluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

@@ -9,13 +9,13 @@
Please ensure that your Azure Event Hubs resource is in US East, US East 2, or West Europe
region. AAD Role Based Access Control is not supported in other regions yet.

Register a new application in AAD and assign the "owner" role to it
Register a new application in AAD and assign the "Azure Event Hubs Data Owner (Preview)" role to it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the portal recently, maybe verify if the option still says "(Preview)" in the portal

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it says preview.

@HarshaNalluru
Copy link
Member

Not sure if it is necessary, It's better to add these links in the comments/readme so that the users can learn more about RBAC.

Service Bus RBAC setup – Learn more
Event Hubs RBAC setup – Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants