Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitor OpenTelemetry] Update AKS Detection #33251

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

JacksonWeber
Copy link
Member

Packages impacted by this PR

@azure/monitor-opentelemetry

Describe the problem that is addressed by this PR

The original env var being used will only detect AKS environments when auto-attach occurs. The new env var being checked will add support for when manual attach is used.

Are there test cases added in this PR? (If not, why?)

Yes

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@JacksonWeber JacksonWeber merged commit 61a07ac into Azure:main Feb 28, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants