[dev-tool] Work around two minor issues #33250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
requested review from
jeremymeng,
mpodwysocki and
timovv
as code owners
github-actions
bot
added
the
dev-tool
jeremymeng
approved these changes
Feb 28, 2025
HarshaNalluru
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
dev-toolDescribe the problem that is addressed by this PR
One issue is VS Code using up a ton of memory and the TS language service crashing when viewing a
.jsfile. This was fixed by adding ajsconfig.jsonfile. I figured this out from this comment: microsoft/vscode#235547 (comment)The other issue is I wanted to be able to run dev-tool from outside of a project folder when using admin commands (like listing all projects, checking migration progress, etc) but
register.jsalways tries to load a localpackage.jsonand throws if you are in a folder without one so I put a simple check to see if the file exists.