[Monitor OpenTelemetry Exporter] Don't Apply Cloud Tags to Statsbeat Telemetry #33229
+49
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonWeber
requested review from
hectorhdzg,
harsimar and
MSNev
as code owners
|
API change check API changes are not detected in this pull request. |
MSNev
approved these changes
Feb 28, 2025
Merged
3 tasks
JacksonWeber
added a commit
that referenced
this pull request
Mar 5, 2025
… Also Remove sdkVersion (#33281) ### Packages impacted by this PR @azure/monitor-opentelemetry-exporter ### Issues associated with this PR ### Describe the problem that is addressed by this PR From #33229 when removing the cloud attributes, the sdkVersion is also removed unintentionally. This PR fixes that mistake and adds a test case to ensure this is not possible in the future. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/monitor-opentelemetry-exporter
Describe the problem that is addressed by this PR
We shouldn't apply the cloud tags to our statsbeat telemetry as it isn't needed.
Are there test cases added in this PR? (If not, why?)
Yes
Checklists