Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates of @azure-rest/ai-vision-face #29676

Merged
merged 11 commits into from
May 23, 2024

Conversation

chungshengfu
Copy link
Contributor

@chungshengfu chungshengfu commented May 13, 2024

Packages impacted by this PR

@azure-rest/ai-vision-face

Issues associated with this PR

Describe the problem that is addressed by this PR

  1. tsp-client update to Azure/azure-rest-api-specs@60161e2 (commit)
  2. Refine customization to not set MFD filename when there has already been one. (commit)
  3. Use the extraFiles config to copy sample images. (commit)
  4. Fix sanitizer issues in tests. (commit)
  5. Update the core-lro to v3 preview version. (commit)
  6. tsp-client update to Azure/azure-rest-api-specs@1d2253d (commit)

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

@azure-rest/ai-vision-face

Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As offline discussed please confirm the folder structure with PM to address the issue

@MaryGao MaryGao requested a review from joheredi May 14, 2024 01:32
@chungshengfu chungshengfu changed the title Ai vision face update Updates of @azure-rest/ai-vision-face May 16, 2024
@chungshengfu chungshengfu force-pushed the ai-vision-face-update branch from 69e46b4 to 1aa10de Compare May 16, 2024 06:42
@chungshengfu

This comment was marked as outdated.

This comment was marked as outdated.

@chungshengfu

This comment was marked as outdated.

This comment was marked as outdated.

@chungshengfu

This comment was marked as outdated.

This comment was marked as outdated.

@MaryGao

This comment was marked as outdated.

This comment was marked as outdated.

@MaryGao

This comment was marked as outdated.

This comment was marked as outdated.

@chungshengfu chungshengfu force-pushed the ai-vision-face-update branch from 7aab9d9 to a6e0520 Compare May 17, 2024 06:27
@chungshengfu

This comment was marked as outdated.

This comment was marked as outdated.

@chungshengfu
Copy link
Contributor Author

/azp run prepare-pipelines

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chungshengfu
Copy link
Contributor Author

/azp run js - core - ci

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@chungshengfu
Copy link
Contributor Author

/azp run js - face - ci

Copy link

No pipelines are associated with this pull request.

@MaryGao
Copy link
Member

MaryGao commented May 17, 2024

/azp run js - face - ci

Copy link

No pipelines are associated with this pull request.

@MaryGao
Copy link
Member

MaryGao commented May 17, 2024

/azp run js - face - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chungshengfu chungshengfu force-pushed the ai-vision-face-update branch 3 times, most recently from 0dab1a4 to 603daf0 Compare May 21, 2024 03:27
@chungshengfu chungshengfu force-pushed the ai-vision-face-update branch from 603daf0 to 9e3a10a Compare May 22, 2024 06:23
Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao dismissed their stale review May 23, 2024 02:10

The structure is finalized with PM.

Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao

This comment was marked as outdated.

This comment was marked as off-topic.

@MaryGao MaryGao merged commit 39cfc07 into Azure:main May 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants