Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS for all /sdk/.../...-rest/ paths. #24842

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Add CODEOWNERS for all /sdk/.../...-rest/ paths. #24842

merged 2 commits into from
Feb 13, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Feb 13, 2023 •
edited
Loading

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 13, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 13, 2023
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 13, 2023
Merged
@konrad-jamrozik konrad-jamrozik changed the title Add CODEOWNERS for few /sdk/.../...-rest/ paths. Add CODEOWNERS for all /sdk/.../...-rest/ paths. Feb 13, 2023
@qiaozha
Copy link
Member

qiaozha commented Feb 13, 2023

/check-enforcer override

@qiaozha
Copy link
Member

qiaozha commented Feb 13, 2023

@konrad-jamrozik LGTM, feel free to merge this PR.

@konrad-jamrozik
Copy link
Contributor Author

@jsquire I should also update fabricbot.json, by adding appropriate entries, yes? E.g. like this line but for arm-appservice-rest.

@jsquire
Copy link
Member

jsquire commented Feb 13, 2023

@jsquire I should also update fabricbot.json, by adding appropriate entries, yes? E.g. like this line but for arm-appservice-rest.

Maybe? I don't see any "Service Attention" labels attached to these. Are they intended to just be PR review paths?

@konrad-jamrozik
Copy link
Contributor Author

@jsquire I should also update fabricbot.json, by adding appropriate entries, yes? E.g. like this line but for arm-appservice-rest.

Maybe? I don't see any "Service Attention" labels attached to these. Are they intended to just be PR review paths?

Thanks! In any case, I went ahead and did it in this commit, as it seemed the right thing to do based on existing rules.

@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit 5293c83 into main Feb 13, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/rest branch February 13, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@qiaozha qiaozha qiaozha approved these changes

@benbp benbp Awaiting requested review from benbp

@jsquire jsquire Awaiting requested review from jsquire

@ronniegeraghty ronniegeraghty Awaiting requested review from ronniegeraghty

Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@konrad-jamrozik @qiaozha @jsquire @weshaggard