Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] Add abortSignal as an optional property to all of the relevant interfaces #4357

Closed
sadasant opened this issue Jul 19, 2019 · 0 comments · Fixed by #4383
Closed

[KeyVault] Add abortSignal as an optional property to all of the relevant interfaces #4357

sadasant opened this issue Jul 19, 2019 · 0 comments · Fixed by #4383
Assignees
@sadasant
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@sadasant
Copy link
Contributor

Even though we support abortSignal, it needs to be explicitly defined in the API to compiler properly. See: https://github.com/Azure/azure-sdk-for-js/pull/4343/files#diff-91e6187853dc6c6c676058faaa81d8e2R7
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jul 19, 2019
@sadasant sadasant self-assigned this Jul 19, 2019
@sadasant sadasant mentioned this issue Jul 19, 2019
Merged
sadasant added a commit to sadasant/azure-sdk-for-js that referenced this issue Jul 22, 2019
@sadasant
[KeyVault] Adds abortSignal to all the *Options we have in keys and s…
9d4459e 
…ecrets

With these changes, our current API fully supports cancelling a request
before we get a response. The idea is that this feature is already
supported by the core dependencies we use, and by passing this property
through, we'll get the benefits right away without having to do other
changes.

keyvault-keys and keyvault-secrets currently have a unit test that
proves that this works for one of the functions that shares this
underlying APIs. This PR adds the support to the other similar methods.
We could also add other tests demonstrating this behavior for these
other functions.

Fixes Azure#4357
@sadasant sadasant mentioned this issue Jul 22, 2019
Merged
sadasant added a commit that referenced this issue Jul 23, 2019
@sadasant
[KeyVault] Adds abortSignal to all the *Options we have in keys and s…
5514e80 
…ecrets (#4383)

With these changes, our current API fully supports cancelling a request
before we get a response. The idea is that this feature is already
supported by the core dependencies we use, and by passing this property
through, we'll get the benefits right away without having to do other
changes.

keyvault-keys and keyvault-secrets currently have a unit test that
proves that this works for one of the functions that shares this
underlying APIs. This PR adds the support to the other similar methods.
We could also add other tests demonstrating this behavior for these
other functions.

Fixes #4357
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
1 participant
@sadasant