Skip to content

Commit

Permalink
Set implicitlyPreferredVersions=false (#6290)
Browse files Browse the repository at this point in the history
- Required to support dependencies with incompatible peerDependencies ranges
- Reverts two workarounds which are no longer necessary
  - strictPeerDependencies=false
  - rhea-promise in preferredVersions
  • Loading branch information
mikeharder authored Nov 21, 2019
1 parent 75b96e1 commit 07c3a55
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 367 deletions.
18 changes: 13 additions & 5 deletions common/config/rush/common-versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,20 @@
* instead of the latest version.
*/
// "some-library": "1.2.3"

// This is required to allow for backward compatibility with Service Bus Track 1
// Workaround for microsoft/web-build-tools#1415
// TODO: Remove this once Service Bus is updated to use current depenedencies as part of Track 2
"rhea-promise": "^0.1.15"
},
/**
* When set to true, for all projects in the repo, all dependencies will be automatically added as preferredVersions,
* except in cases where different projects specify different version ranges for a given dependency. For older
* package managers, this tended to reduce duplication of indirect dependencies. However, it can sometimes cause
* trouble for indirect dependencies with incompatible peerDependencies ranges.
*
* The default value is true. If you're encountering installation errors related to peer dependencies,
* it's recommended to set this to false.
*
* After modifying this field, it's recommended to run "rush update --full" so that the package manager
* will recalculate all version selections.
*/
"implicitlyPreferredVersions": false,
/**
* The "rush check" command can be used to enforce that every project in the repo must specify
* the same SemVer range for a given dependency. However, sometimes exceptions are needed.
Expand Down
Loading

0 comments on commit 07c3a55

Please sign in to comment.