Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos Issue #6250: Address memory leak in RntbdRequestTimer #6251

Merged
merged 6 commits into from
Nov 14, 2019
Merged

Cosmos Issue #6250: Address memory leak in RntbdRequestTimer #6251

merged 6 commits into from
Nov 14, 2019

Conversation

David-Noble-at-work
Copy link

@David-Noble-at-work David-Noble-at-work commented Nov 9, 2019 •
edited
Loading

Resolves:

Also:

  • Renames RntbdRequestRecord.stateUpdater as RntbdRequestRecord.stageUpdater
  • Fixes spelling errors in benchmark logger configuration
  • Tidies RntbdTransportClient

David Noble added 4 commits November 8, 2019 16:15
@David-Noble-at-work
Copy link
Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@David-Noble-at-work David-Noble-at-work self-assigned this Nov 9, 2019
@David-Noble-at-work
Copy link
Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@David-Noble-at-work David-Noble-at-work changed the title DRAFT: Cosmos Direct TCP: Address memory leak in RntbdRequestTimer Cosmos Direct TCP: Address memory leak in RntbdRequestTimer Nov 9, 2019
@David-Noble-at-work David-Noble-at-work marked this pull request as ready for review November 9, 2019 17:20
This was referenced Nov 9, 2019
Closed
Closed
Closed
Merged
@David-Noble-at-work David-Noble-at-work changed the title Cosmos Direct TCP: Address memory leak in RntbdRequestTimer Cosmos Issue #6250: Address memory leak in RntbdRequestTimer Nov 9, 2019
@David-Noble-at-work
Copy link
Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

kushagraThapar
kushagraThapar approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kushagraThapar kushagraThapar merged commit 584a7ac into Azure:feature/cosmos/v4 Nov 14, 2019
@David-Noble-at-work David-Noble-at-work mentioned this pull request Dec 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@moderakh moderakh moderakh approved these changes

Assignees

@David-Noble-at-work David-Noble-at-work

Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@David-Noble-at-work @kushagraThapar @moderakh